Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive goroutines in recording proxy #1966

Closed
russjones opened this issue May 18, 2018 · 0 comments · Fixed by #1993
Closed

Excessive goroutines in recording proxy #1966

russjones opened this issue May 18, 2018 · 0 comments · Fixed by #1993

Comments

@russjones
Copy link
Contributor

russjones commented May 18, 2018

Problem

The recording proxy uses 10k goroutines for the same load as a Teleport node which uses 1k goroutines during testing. This is due to the keepAliveLoop in lib/forward/sshserver.go.

This function ticks every 5 minutes and waits for 3 ticks before closing. Instead this function should return as soon as the server is closed. The tick period can also be reduced from 5 minutes to maybe 1 minute.

@russjones russjones added this to the 2.6.1 "New Braunfels" milestone May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant