Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins intergration #164

Closed
2 tasks done
klizhentas opened this issue Feb 24, 2016 · 4 comments
Closed
2 tasks done

jenkins intergration #164

klizhentas opened this issue Feb 24, 2016 · 4 comments
Assignees

Comments

@klizhentas
Copy link
Contributor

Description

Before going OSS we need to have a better jenkins intergration, in particular we need to test every PR that comes our way. so we can be sure it does not break anything

How success looks like

When anyone submits a new PR, the following happens

  • go test -v ./... passes
  • go vet ./lib ./tool passes

If any of the steps above is failed, the branch should not be merged and this should be displayed by jenkins-bot in the PR.

@klizhentas
Copy link
Contributor Author

@kontsevoy kontsevoy self-assigned this Feb 25, 2016
@kontsevoy
Copy link
Contributor

BTW I'm blocked by #180. Besides, I aways get this error (not rare at all):

FAIL: web_test.go:545: WebSuite.TestConnect

web_test.go:571:
    c.Assert(removeSpace(output.String()), Matches, ".*176.*")
... value string = "$ expr 137 + 39    exit      disconnected"
... regex string = ".*176.*"

@klizhentas
Copy link
Contributor Author

that's what I'm doing the whole day today - running tests in endless loops and looking at what is failing and why

@klizhentas klizhentas assigned klizhentas and unassigned kontsevoy Mar 11, 2016
@klizhentas
Copy link
Contributor Author

implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants