Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleport does not wrap long lines correctly upon first login. #1087

Closed
russjones opened this issue Jun 20, 2017 · 7 comments
Closed

Teleport does not wrap long lines correctly upon first login. #1087

russjones opened this issue Jun 20, 2017 · 7 comments
Assignees
Labels

Comments

@russjones
Copy link
Contributor

russjones commented Jun 20, 2017

Problem

On initially connecting to a Teleport node, long lines of text don't wrap correctly until terminal is resized.

Reproduction

  1. Start Teleport.
  2. Open Terminal.app and resize to 80x24.
  3. Use tsh or ssh to connect to a Teleport node.
  4. Paste aaaaaaaaaabbbbbbbbbbccccccccccddddddddddeeeeeeeeeeffffffffffgggggggggghhhhhhhhhhiiiiiiiiiijjjjjjjjjjkkkkkkkkkkllllllllllmmmmmmmmmmnnnnnnnnnnoooooooooopppppppppp in Terminal.app.
  5. You'll see something like nnooooooooooppppppppppiiiiiiiiijjjjjjjjjjkkkkkkkkkkllllllllllmmmmmmmmmmnnnnnnnn. This is incorrect.
  6. Resize Terminal.app and you'll see the text wrap correctly.
  7. Paste another long line and you will see text wrap correctly.
@kontsevoy kontsevoy added this to the 2.3 milestone Jun 20, 2017
@kontsevoy kontsevoy self-assigned this Jun 20, 2017
@kontsevoy kontsevoy added the bug label Jun 20, 2017
@aashley
Copy link

aashley commented Jul 26, 2017

This also happens in linux on gnome-terminal 3.18.3, mate-terminal 1.12.1, xterm(322). Resizing the window doesn't help with these. And despite comments in #926 this only occurs in tsh, all other apps wrap correctly.

@kontsevoy
Copy link
Contributor

kontsevoy commented Jul 28, 2017

@aashley I am having a problem interpreting "all other apps" comment. tsh is basically a tunnel connecting your terminal app (gnome-terminal) to a server-allocated PTY. Then on top of that you're running CLI apps like bash. So there's always tsh + all other apps, not "or".

This bug is about tsh not communicating the size of the server-allocated PTY to gnome-terminal which leads to this behavior. (will be fixed)

What we're trying to determine how can this be reproduced beyond initial resize for BOTH use cases:

  • incorrect behavior with tsh
  • correct behavior with ssh

@aashley
Copy link

aashley commented Jul 28, 2017

I'm not sure how else to reproduce this. It happens on every connection through tsh for me.

  1. Start gnome-terminal with bash as shell.
  2. connect to remote server using ssh starting bash remotely
  3. type long text and it wraps onto new line correctly, resize gnome-terminal continues to wrap correctly
  4. connect to same remote server using tsh starting bash remotely
  5. type long text and it wraps onto the same line, resize gnome-terminal and continues to wrap incorrectly.

If I launch byobu within the tsh connection it takes over and the wrapping works correctly. It only when in the basic shell directly in tsh that the wrapping fails for me. I've only tested with bash though.

@kontsevoy
Copy link
Contributor

@aashley gotcha, this is perfect (regular ssh appears to work perfectly). Which Gnome version you're on? We'll try to nail this one for 2.4

@aashley
Copy link

aashley commented Jul 29, 2017

Not actually using gnome, using Ubuntu Mate 16.04 with the earlier mentioned terminals and versions.

@patrobinson
Copy link

I have a similar issue using iTerm 2 on MacOS X Sierra. When connecting to a host with ssh, the terminal wraps commands correctly. When connecting with tsh it does not until I resize the window

@kontsevoy
Copy link
Contributor

I tried 2.4 and cannot reproduce it. WIll try again later, but punting for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants