Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scrolling doesn't work in all of the columns of Schema in Electron app #885

Closed
1 of 7 tasks
davidrf opened this issue Nov 15, 2018 · 4 comments
Closed
1 of 7 tasks

Comments

@davidrf
Copy link
Contributor

davidrf commented Nov 15, 2018

This issue pertains to the following package(s):

  • GraphQL Playground - Electron App
  • GraphQL Playground HTML
  • GraphQL Playground
  • GraphQL Playground Express Middleware
  • GraphQL Playground Hapi Middleware
  • GraphQL Playground Koa Middleware
  • GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

MacOs High Sierra 10.13.6

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

1.8.2 graphql-playground-electron

What is the expected behavior?

When the content of any column of the schema view overflows, a vertical scroll bar appears allowing the user to scroll in order to view all the content in the column.

What is the actual behavior?

When the content of any column of the schema view overflows, the content is cut off at the bottom of the column. The only exception is the leftmost column which works as expected.

What steps may we take to reproduce the behavior?

View a schema with lots of types and/or resize the window so the app window height is less than the content of a column.

Please provide a gif or image of the issue for a quicker response/fix.
screen shot 2018-11-15 at 3 56 12 pm
In the image above the leftmost column in the schema view has a grey scroll bar to allow you to scroll to view all the available queries and mutations. However, the middle and rightmost columns in the schema view do not have such a scroll bar. Thus, it is not possible to view all the fields in the middle column or view all the implementations in the rightmost column

Also, there was a previous issue #883 which attempted to fix the same problem, but didn't fix it for all columns in the schema view for the Electron app.

@davidrf davidrf changed the title Vertical scrolling doesn't work in all of the columns of Schema Vertical scrolling doesn't work in all of the columns of Schema in Electron app Nov 16, 2018
@effektsvk
Copy link

Today, I've installed a new update and the issue still persists... The overflow: auto CSS is still missing and when I add it via Dev Tools it works.

@huv1k
Copy link
Collaborator

huv1k commented Nov 30, 2018

Still problem with safari.

@huv1k huv1k reopened this Nov 30, 2018
@kimobrian
Copy link

This is the case for the Desktop app too

@effektsvk
Copy link

Yay, this update finally fixed it, for real. I think the issue can be closed now 🎉

@huv1k huv1k closed this as completed Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants