You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Without standard flow-type outputs in graphql's package.
Some packages dependent on graphql get more and more wrong flow-type check.(used wrong type but type-check passed in that package).
Ex: graphql-relay-js,It used a subset of graphql.
But cause there is no flow-type output in graphql's standard npm package, so graphql-relay-js can do type check arbitrarily, this will lend to some bugs.
Like graphql-relay-js :
type typeResolverFn = (object: any) => ?GraphQLObjectType |
(object: any) => ?Promise<GraphQLObjectType>; // wrong ? type can not be resolved with a Promise?
And also if there are type-outputs in graphql
Something in graphql(L469):
export type GraphQLFieldResolveFn = (
source: mixed,
args: {[argName: string]: mixed}, // should be modified to args:Object or some template?
context: mixed,
info: GraphQLResolveInfo
) => mixed
would be narrowed rightly in graph-relay like this:
Without standard flow-type outputs in
graphql
's package.Some packages dependent on
graphql
get more and more wrong flow-type check.(used wrong type but type-check passed in that package).Ex: graphql-relay-js,It used a subset of graphql.
But cause there is no flow-type output in
graphql
's standard npm package, sographql-relay-js
can do type check arbitrarily, this will lend to some bugs.Like
graphql-relay-js
:vs
grapgql
'sAnd also if there are type-outputs in
graphql
Something in
graphql
(L469):would be narrowed rightly in
graph-relay
like this:The text was updated successfully, but these errors were encountered: