You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@benjie we haven't even gotten to #1165 yet, however already conventional commits angular preset (the lerna default) wants this:
this is what i get upon running lerna publish --no-git-tag-version --no-push --registry=fake locally, for a dry run essentially. I usually run it with lerna publish --otp <otp> if I want to actually publish. It of course inherits the underlying lerna.json args which include conventionalCommits, etc.
because of the commit with the breaking change flag #1106
(both of these were simulated in a dry run)
before, lerna publish has been perfect for automatically bumping versions, but it was this use of the BREAKING CHANGE footer prefix in the react 15 support drop commit that is forcing a major version bump.
This tool has been to our great advantage, so that we don't have to go around and manually reference the latest interdependent versions in every release like before. That is what lerna publish already does, by running both version and publish in the same command, allowing the interdependent.
We can just revise the commit log to remove that entry and only use that for the next stable release as we have planned, or (more complex) we implement our own conventional changelog preset, and configure lerna to use that which would be a bit more complex but is also certainly possible. (note: we can use lerna.json extends, I don't think it's in documentation but its in the code, allows you to load CJS configs for lerna commands for example (different environments, etc)
The text was updated successfully, but these errors were encountered:
acao
changed the title
Automated conventional commits wants us to
Automated conventional commits wants us to bump GraphiQL to 1.0.0
Dec 28, 2019
@benjie we haven't even gotten to #1165 yet, however already conventional commits angular preset (the lerna default) wants this:
this is what i get upon running

lerna publish --no-git-tag-version --no-push --registry=fake
locally, for a dry run essentially. I usually run it withlerna publish --otp <otp>
if I want to actually publish. It of course inherits the underlying lerna.json args which includeconventionalCommits
, etc.because of the commit with the breaking change flag #1106
(both of these were simulated in a dry run)
before,
lerna publish
has been perfect for automatically bumping versions, but it was this use of theBREAKING CHANGE
footer prefix in the react 15 support drop commit that is forcing a major version bump.This tool has been to our great advantage, so that we don't have to go around and manually reference the latest interdependent versions in every release like before. That is what
lerna publish
already does, by running both version and publish in the same command, allowing the interdependent.We can just revise the commit log to remove that entry and only use that for the next stable release as we have planned, or (more complex) we implement our own conventional changelog preset, and configure lerna to use that which would be a bit more complex but is also certainly possible. (note: we can use lerna.json
extends
, I don't think it's in documentation but its in the code, allows you to load CJS configs for lerna commands for example (different environments, etc)The text was updated successfully, but these errors were encountered: