Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated conventional commits wants us to bump GraphiQL to 1.0.0 #1172

Closed
acao opened this issue Dec 28, 2019 · 1 comment
Closed

Automated conventional commits wants us to bump GraphiQL to 1.0.0 #1172

acao opened this issue Dec 28, 2019 · 1 comment
Labels

Comments

@acao
Copy link
Member

acao commented Dec 28, 2019

@benjie we haven't even gotten to #1165 yet, however already conventional commits angular preset (the lerna default) wants this:

this is what i get upon running lerna publish --no-git-tag-version --no-push --registry=fake locally, for a dry run essentially. I usually run it with lerna publish --otp <otp> if I want to actually publish. It of course inherits the underlying lerna.json args which include conventionalCommits, etc.
Screen Shot 2019-12-28 at 3 51 43 PM

because of the commit with the breaking change flag #1106

Screen Shot 2019-12-28 at 3 56 27 PM

(both of these were simulated in a dry run)

before, lerna publish has been perfect for automatically bumping versions, but it was this use of the BREAKING CHANGE footer prefix in the react 15 support drop commit that is forcing a major version bump.

This tool has been to our great advantage, so that we don't have to go around and manually reference the latest interdependent versions in every release like before. That is what lerna publish already does, by running both version and publish in the same command, allowing the interdependent.

We can just revise the commit log to remove that entry and only use that for the next stable release as we have planned, or (more complex) we implement our own conventional changelog preset, and configure lerna to use that which would be a bit more complex but is also certainly possible. (note: we can use lerna.json extends, I don't think it's in documentation but its in the code, allows you to load CJS configs for lerna commands for example (different environments, etc)

@acao acao changed the title Automated conventional commits wants us to Automated conventional commits wants us to bump GraphiQL to 1.0.0 Dec 28, 2019
@acao acao added the bug label Dec 28, 2019
@acao
Copy link
Member Author

acao commented Jan 9, 2020

this is actually what we want, we decided after some discussion

@acao acao closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
@acao and others