From bfd95e0d0fb97963d459316dd6fac74e865acb3f Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Tue, 27 Feb 2024 21:31:47 +0100 Subject: [PATCH] add comments --- .../src/__tests__/MessageProcessor.spec.ts | 7 +++++-- .../src/__tests__/__utils__/MockProject.ts | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts b/packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts index df83013aa15..9110badfe3b 100644 --- a/packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts +++ b/packages/graphql-language-service-server/src/__tests__/MessageProcessor.spec.ts @@ -327,7 +327,7 @@ describe('project with simple config and graphql files', () => { position: { character: 20, line: 17 }, }); expect(schemaDefs[0].uri).toEqual(URI.parse(genSchemaPath).toString()); - // note: if the graphiql test schema changes, + // note: if the graphiql test schema changes, // this might break, please adjust if you see a failure here expect(serializeRange(schemaDefs[0].range)).toEqual({ start: { @@ -436,7 +436,10 @@ describe('project with simple config and graphql files', () => { // 'b/schema.graphql', // schemaFile[1] + '\ntype Example1 { field: }', // ); - // TODO: this didn't work at all, how to register incomplete changes to model autocomplete, etc? + // TODO: this didn't work at all for multi project, + // whereas a schema change works above in a single schema context as per updating the cache + // + // how to register incomplete changes to model autocomplete, etc? // await project.lsp.handleWatchedFilesChangedNotification({ // changes: [ // { uri: project.uri('b/schema.graphql'), type: FileChangeType.Changed }, diff --git a/packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts b/packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts index 999066290c6..6cd215a9424 100644 --- a/packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts +++ b/packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts @@ -4,7 +4,6 @@ import { Logger as VSCodeLogger } from 'vscode-jsonrpc'; import { URI } from 'vscode-uri'; import { FileChangeType } from 'vscode-languageserver'; import { FileChangeTypeKind } from 'graphql-language-service'; -import { mock } from 'fetch-mock'; export type MockFile = [filename: string, text: string]; @@ -74,6 +73,7 @@ export class MockProject { loadConfigOptions: { rootDir: root }, }); } + public async init(filename?: string, fileText?: string) { await this.lsp.handleInitializeRequest({ rootPath: this.root,