From 47e673d34b70e5bfb6bdc87d21643a823828b9ad Mon Sep 17 00:00:00 2001 From: Dimitri POSTOLOV Date: Sun, 25 Jun 2023 01:30:15 +0200 Subject: [PATCH] enable `prefer-arrow-callback` (#3282) --- .eslintrc.js | 2 +- packages/graphiql/resources/renderExample.js | 21 ++++++++------------ 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 23b813fb86a..62919fc4bd3 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -248,12 +248,12 @@ module.exports = { 'no-useless-computed-key': 'error', 'no-useless-constructor': 'off', 'no-useless-rename': 'error', + 'prefer-arrow-callback': ['error', { allowNamedFunctions: true }], 'object-shorthand': [ 'error', 'always', { avoidExplicitReturnArrows: true }, ], - 'prefer-arrow-callback': ['off', { allowNamedFunctions: true }], // prettier --list-different 'prefer-numeric-literals': 'off', 'prefer-template': 'off', 'sort-imports': 'off', diff --git a/packages/graphiql/resources/renderExample.js b/packages/graphiql/resources/renderExample.js index 80f3258c7a2..8e8e44ca096 100644 --- a/packages/graphiql/resources/renderExample.js +++ b/packages/graphiql/resources/renderExample.js @@ -49,19 +49,14 @@ function onTabChange(tabsState) { } function updateURL() { - const newSearch = - '?' + - Object.keys(parameters) - .filter(function (key) { - return Boolean(parameters[key]); - }) - .map(function (key) { - return ( - encodeURIComponent(key) + '=' + encodeURIComponent(parameters[key]) - ); - }) - .join('&'); - history.replaceState(null, null, newSearch); + const newSearch = Object.entries(parameters) + .filter(([_key, value]) => value) + .map( + ([key, value]) => + encodeURIComponent(key) + '=' + encodeURIComponent(value), + ) + .join('&'); + history.replaceState(null, null, `?${newSearch}`); } function getSchemaUrl() {