Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] deployment_sync_secs metrics still emitted for synced subgraphs #4784

Open
1 of 3 tasks
brianluong opened this issue Jul 26, 2023 · 3 comments
Open
1 of 3 tasks
Labels
bug Something isn't working Stale

Comments

@brianluong
Copy link

Bug report

We're still seeing deployment_sync_secs metrics still emitted for synced subgraphs on v0.31.0.

Specifically, we're still seeing these metrics emitted only when the indexer starts up.

I think this PR was intended to solve this in v0.31.0, but it doesn't seem it fully addresses the issue.

image

Relevant log output

No response

IPFS hash

No response

Subgraph name or link to explorer

No response

Some information to help us out

  • Tick this box if this bug is caused by a regression found in the latest release.
  • Tick this box if this bug is specific to the hosted service.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

OS information

None

@brianluong brianluong added the bug Something isn't working label Jul 26, 2023
@lutter
Copy link
Collaborator

lutter commented Aug 9, 2023

When graph-node starts up, it assumes all subgraphs are not synced; once it processes a block, it determines whether the subgraph is synced and then turns off recording the metric. Depending on how long graph-node was shut down, it can take a bit of time for it to catch up to the chain head. During that time, it will record deployment_sync_secs.

Is that causing an issue for you?

@brianluong
Copy link
Author

We noticed deployment_sync_secs for synced subgraphs was a significant contributor to our metrics usage.

To us (and maybe others) deployment_sync_secs are only interesting until the subgraph has synced.

Copy link

github-actions bot commented Feb 7, 2024

Looks like this issue has been open for 6 months with no activity. Is it still relevant? If not, please remember to close it.

@github-actions github-actions bot added the Stale label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants