Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VueUiTableSparkline Several problems encountered #144

Closed
khcshell opened this issue Dec 23, 2024 · 17 comments
Closed

VueUiTableSparkline Several problems encountered #144

khcshell opened this issue Dec 23, 2024 · 17 comments
Labels
enhancement New feature or request

Comments

@khcshell
Copy link

image
1.As shown in the figure, when you click on the sort, there will be a chamfered grid around it, which should be the wrong display
2.Click sorting,It will cause the grid to be stretched open because of the appearance of the arrow,Affect the size of the layout,My suggestion is 1,The sorting function is optional,When you turn it off, the arrow will not be displayed,Turn on this function Sorting arrow has always existed,This problem can be avoided
2. Turn off the sorting function for some columns, because some columns don't need to be sorted, and some data columns may need to be sorted

@graphieros
Copy link
Owner

graphieros commented Dec 23, 2024

@khcshell

  1. ok
  2. ok
  3. ok

@graphieros
Copy link
Owner

graphieros commented Dec 23, 2024

@khcshell

You can upgrade to v2.4.49.
Explanations in the release.

Documentation website is up to date

@khcshell
Copy link
Author

@graphieros
1.The icons in forward order and reverse order should be different, for example, in positive order ⬆, in reverse order ⬇, not now, which would ⬆⬇ be confusing.
2. I didn't find a feature that could turn off sorting, because this feature is not used every time
3. I also can't find to turn off the sorting of some columns, for example, I only need the last 2 columns to sort, then the front column has a sorting function is not suitable

@graphieros
Copy link
Owner

graphieros commented Dec 24, 2024

@khcshell
Everything is explained on the release.

sortedDataColumnIndices: [], // use indexes of columns to sort. If empty array, no data column will have the sort
sortedSeriesName: false,
sortedSum: false,
sortedAverage: false,
sortedMedian: false,
resetSortOnClickOutside: false,

@khcshell
Copy link
Author

@graphieros
I see, This is great
1.The icons in forward order and reverse order should be different, for example, in positive order ⬆, in reverse order ⬇, not now, which would ⬆⬇ be confusing.
Will this be changed?

@graphieros
Copy link
Owner

Yes, I'm working on it

@graphieros
Copy link
Owner

@khcshell

You can upgrade to v2.4.50 which improves arrows.

@graphieros graphieros added the enhancement New feature or request label Dec 24, 2024
@khcshell
Copy link
Author

@graphieros
image
Do you think it would be better to make the forward and reverse order 2 buttons clicked, and the two are mutually exclusive? If they are all canceled, the original order will be maintained

@graphieros
Copy link
Owner

@khcshell

If I put 2 buttons up and down, what do you think about this behavior:

  • click UP once : sort up
  • click UP a second time: restore order

And:

  • click UP once: sort up
  • click DOWN once: sort down

I'm just afraid buttons are very close in your design, misclick could be easy and frustrating.

@khcshell
Copy link
Author

@graphieros
click UP once: sort up ,click UP second: Cancel sort up
click DOWN once: sort down,click DOWN second: Cancel sort down
and UP, DOWN, click on one, and the other will be automatically canceled. Mutually exclusive

In addition, I recommend placing buttons left and right, it is easy to click on the upper and lower stages, and the spacing between the left and right can be adjusted to avoid this problem

@graphieros
Copy link
Owner

@khcshell

[DOWN] { label } [UP] ?

@khcshell
Copy link
Author

@graphieros
image

  1. Click on A to sort forward, then click on A to cancel the forward sort, and in the same way click on B to reverse the sort, and then click on B to cancel the reverse sort
  2. When you click on A, B will automatically uncheck the state, and when you click on B, you will uncheck the state at A to ensure that the forward and reverse directions will not be activated at the same time
  3. As shown in the figure, the interval can be adjusted in the middle, so that you will not click on it wrongly

@khcshell
Copy link
Author

like this
image

@graphieros
Copy link
Owner

graphieros commented Dec 26, 2024

Ok, I'll just expose a css class for these buttons, no need for additional config for this

@graphieros
Copy link
Owner

graphieros commented Dec 26, 2024

@khcshell

You can upgrade to v2.4.54

@khcshell
Copy link
Author

@graphieros
expose a css class for these buttons

Can you write me an example? I didn't succeed in this adjustment

@graphieros
Copy link
Owner

@khcshell

https://stackblitz.com/edit/vitejs-vite-m4jtitod?file=src%2FApp.vue

Just get the classes through inspection, and force styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants