Support for node_modules in graphql imports, attempt 2 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested & working really well! +1 for merging! @schickling are you ok with merging this? |
# Conflicts: # package.json # src/index.ts
SpaceK33z
added a commit
that referenced
this pull request
Sep 7, 2018
This is a continuation of PR #136 from @lfades (spoke to @lfades about this and he was okay with it). It uses `resolve-from` instead of `require.resolve` with the `paths` option because it is not compatible with Node < 8. Also I think this one works a bit differently; it doesn't introduce a breaking change since it will first try to look up the path relative to the file the import is in, and only if that fails it will use `resolve-from`. Fixes #57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of PR #136 from @lfades (spoke to @lfades about this and he was okay with it).
It uses
resolve-frominstead ofrequire.resolvewith thepathsoption because it is not compatible with Node < 8.Also I think this one works a bit differently; it doesn't introduce a breaking change since it will first try to look up the path relative to the file the import is in, and only if that fails it will use
resolve-from.Fixes #57