Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature of customizing the attribute of avatar img #124

Merged
merged 1 commit into from
Mar 23, 2016
Merged

add feature of customizing the attribute of avatar img #124

merged 1 commit into from
Mar 23, 2016

Conversation

Hsinfu
Copy link
Contributor

@Hsinfu Hsinfu commented Mar 22, 2016

Here is my way to customize the attribute of avatar img.

  1. Take the advantage of kwargs
  2. Pass kwargs as parameter to template instead of unrolling it
  3. For loop in the template to unroll the kwargs

I also modified the document.

@grantmcconnaughey Can you help to see if there is something missing. Thx.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.4% when pulling 9ab18a7 on Hsinfu:custom_avatar_img_attr into f0c45af on grantmcconnaughey:master.

@grantmcconnaughey grantmcconnaughey merged commit e3b1e69 into jazzband:master Mar 23, 2016
@grantmcconnaughey
Copy link
Contributor

Nice, I like it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants