Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Pass the correct reference in the trace for remote/local screenshots #1161

Closed
2 tasks
ankur22 opened this issue Jan 17, 2024 · 1 comment
Closed
2 tasks

Pass the correct reference in the trace for remote/local screenshots #1161

ankur22 opened this issue Jan 17, 2024 · 1 comment
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 17, 2024

What?

Ensure that the correct reference to the screenshot is set as an attribute to the span when the screenshot is persisted to the local disk or to a remote location. Currently it works with local disk persistence.

Why?

We want to keep track of the screenshot in a span and within it an attribute which details appropriate information on the name of the file and where the screenshot has been persisted.

How?

TBD

Tasks

Tasks
Preview Give feedback

Related PR(s)/Issue(s)

Prerequisite issue: #1160
@ankur22 ankur22 added team/k6browser To distinguish the issue on project boards. remote remote browser related labels Jan 17, 2024
@ankur22
Copy link
Collaborator Author

ankur22 commented Jan 25, 2024

No changes to the screenshot span are required, and the current path will be sufficient.

@ankur22 ankur22 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
remote remote browser related team/k6browser To distinguish the issue on project boards.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ankur22