Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support environment variable expansion in config file #788

Closed
annanay25 opened this issue Jun 23, 2021 · 1 comment · Fixed by #796
Closed

Support environment variable expansion in config file #788

annanay25 opened this issue Jun 23, 2021 · 1 comment · Fixed by #796
Labels
good first issue Good for newcomers

Comments

@annanay25
Copy link
Contributor

annanay25 commented Jun 23, 2021

Allow adding sensitive information to the config file by expanding environment variables. Some backend drivers have native support for this (ex: GCS/S3) but there might be other instances where this is desired, for instance in Memcached/Redis/Azure/etc.

The solution is to add a new cli option -config.expand-env that will replace any environment variables denoted by ${VAR} in the config file.

This is inspired by Loki inspired by Cortex :)
grafana/loki#2311
https://cortexmetrics.io/docs/configuration/configuration-file/#use-environment-variables-in-the-configuration

Related: #749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants