Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add large traces to k6.io tests #394

Closed
joe-elliott opened this issue Dec 5, 2020 · 3 comments
Closed

Add large traces to k6.io tests #394

joe-elliott opened this issue Dec 5, 2020 · 3 comments

Comments

@joe-elliott
Copy link
Member

Is your feature request related to a problem? Please describe.
We know that tempo has some performance issues returning extremely large traces. Let's add some benchmark testing of this to the k6.io scripts added here: #392 to help us track this issue and improve on it.

@dgzlopes
Copy link
Member

We should create traces with tons of spans? Or with huge spans (size-wise)? Or both?

@joe-elliott
Copy link
Member Author

We have tracked this down to being almost entirely an issue with marshalling/unmarshalling. Removing the jaeger-query dependency and allowing Grafana to query Tempo directly will be the best thing we can do. Also, for clarity, "large traces" are in the couple hundred thousand span range.

I think we can just close this tbh.

@dgzlopes
Copy link
Member

Oh, if that's the case, I agree! We can close this one.

Thanks for the clarification anyway :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants