Upgrade parquet to fix boolean storage #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
requested review from
annanay25,
mdisibio,
mapno,
yvrhdn and
zalegrala
as code owners
Signed-off-by: Joe Elliott <[email protected]>
mdisibio
approved these changes
Apr 28, 2023
This reverts commit db1461c.
|
Hello @joe-elliott!
Please, if the current pull request addresses a bug fix, label it with the |
joe-elliott
added
backport release-v2.1
and removed
missing-labels
backport release-v2.1
labels
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-2400-to-release-v2.1 origin/release-v2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 8339589e5b479d4b617d82ffa6cef130283a5d5a
# Push it to GitHub
git push --set-upstream origin backport-2400-to-release-v2.1
git switch main
# Remove the local backport branch
git branch -D backport-2400-to-release-v2.1Then, create a pull request where the |
joe-elliott
added a commit
that referenced
this pull request
Apr 28, 2023
* update mod Signed-off-by: Joe Elliott <[email protected]> * add bools to tests Signed-off-by: Joe Elliott <[email protected]> * changelog Signed-off-by: Joe Elliott <[email protected]> * Revert "add bools to tests" This reverts commit db1461c. --------- Signed-off-by: Joe Elliott <[email protected]> (cherry picked from commit 8339589)
joe-elliott
added a commit
that referenced
this pull request
Apr 28, 2023
* Upgrade parquet to fix boolean storage (#2400) * update mod Signed-off-by: Joe Elliott <[email protected]> * add bools to tests Signed-off-by: Joe Elliott <[email protected]> * changelog Signed-off-by: Joe Elliott <[email protected]> * Revert "add bools to tests" This reverts commit db1461c. --------- Signed-off-by: Joe Elliott <[email protected]> (cherry picked from commit 8339589) * fix Signed-off-by: Joe Elliott <[email protected]> --------- Signed-off-by: Joe Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates Parquet go to fix the flipping of booleans at storage time.
Which issue(s) this PR fixes:
Fixes #2343
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]