Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Binary without metrics generator logs "value is nil" repeatedly #2048

Closed
joe-elliott opened this issue Feb 1, 2023 · 0 comments · Fixed by #2058
Closed

Single Binary without metrics generator logs "value is nil" repeatedly #2048

joe-elliott opened this issue Feb 1, 2023 · 0 comments · Fixed by #2058
Assignees
Milestone

Comments

@joe-elliott
Copy link
Member

joe-elliott commented Feb 1, 2023

When running the single binary the following is logged repeatedly if the metrics generator is not configured:

level=info ts=2023-02-01T14:18:57.573201626Z caller=client.go:255 msg="value is nil" key=collectors/metrics-generator index=81

This is an innocuous but annoying error message. The root cause is our change to drop the metrics_generator_enabled setting. In the single binary deployment an in memory kv store is used for ring propagation. The metrics generator module is never created and therefore never creates the key that the client expects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant