Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include size of the spans in span metrics #1615

Closed
yvrhdn opened this issue Aug 3, 2022 · 0 comments · Fixed by #1662
Closed

Include size of the spans in span metrics #1615

yvrhdn opened this issue Aug 3, 2022 · 0 comments · Fixed by #1662
Assignees
Milestone

Comments

@yvrhdn
Copy link
Member

yvrhdn commented Aug 3, 2022

Is your feature request related to a problem? Please describe.

In the scenario that Tempo is used by multiple teams and that the costs of each team should be charged back, it is essential to know how much volume each team is generating.
Using the span metrics generated by the metrics-generator, it's possible to know the amount of spans per service, cluster, etc. But not the actual size of those spans.

Describe the solution you'd like

The span metrics processor should (optionally) also omit a metric traces_spanmetrics_bytes_total with the size of each received span. This metric has the same label as the existing span metrics.
This metric will behave very similar to traces_spanmetrics_calls_total, but instead of counting the spans it just adds up the sizes.

Describe alternatives you've considered

You can currently estimate the volume of each team using the average span size. This is probably close enough, but doesn't take into account that some teams might have heavier spans than others.

Additional context

@yvrhdn yvrhdn added this to the Next milestone Aug 3, 2022
@ie-pham ie-pham self-assigned this Aug 15, 2022
@cristiangsp cristiangsp modified the milestones: Next, v2.0 Aug 17, 2022
@cristiangsp cristiangsp moved this to Todo in Tempo squad Aug 17, 2022
Repository owner moved this from Todo to Done in Tempo squad Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants