From c00e7ef1103a8e7804b6f71fe8e90d0a2d9a9b02 Mon Sep 17 00:00:00 2001 From: George Brighton Date: Fri, 24 Nov 2023 08:55:33 +0000 Subject: [PATCH] Fix handling for returned error added in f9100fb (#3176) --- tempodb/encoding/vparquet3/block_autocomplete.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tempodb/encoding/vparquet3/block_autocomplete.go b/tempodb/encoding/vparquet3/block_autocomplete.go index aa7fa6b8411..e8bd765f2ad 100644 --- a/tempodb/encoding/vparquet3/block_autocomplete.go +++ b/tempodb/encoding/vparquet3/block_autocomplete.go @@ -380,7 +380,7 @@ func createDistinctAttributeIterator( if len(valueIters) > 0 || len(iters) > 0 { if len(valueIters) > 0 { - tagIter := parquetquery.NewLeftJoinIterator( + tagIter, err := parquetquery.NewLeftJoinIterator( definitionLevel, []parquetquery.Iterator{makeIter(keyPath, parquetquery.NewStringInPredicate(attrKeys), "key")}, valueIters, @@ -389,6 +389,9 @@ func createDistinctAttributeIterator( keep: keep, }, ) + if err != nil { + return nil, fmt.Errorf("creating left join iterator: %w", err) + } iters = append(iters, tagIter) } return parquetquery.NewJoinIterator(