Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: terraform export fixes #1070

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Fix: terraform export fixes #1070

merged 4 commits into from
Feb 21, 2025

Conversation

VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Feb 19, 2025

Closes #1033, #1028, #1032.

Fixes the export code for terraform to address:

  • Adjust check capabilities format
  • Include check frequency and timeout
  • Omit dns validate fields when empty.

@VikaCep VikaCep self-assigned this Feb 19, 2025
@VikaCep VikaCep marked this pull request as ready for review February 20, 2025 20:54
@VikaCep VikaCep requested a review from a team as a code owner February 20, 2025 20:54
@VikaCep VikaCep requested a review from ckbedwell February 20, 2025 20:54
ckbedwell
ckbedwell approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VikaCep VikaCep merged commit 2089ded into main Feb 21, 2025
7 checks passed
@VikaCep VikaCep deleted the terraform-fixes branch February 21, 2025 14:01
@sm-release-app sm-release-app bot mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckbedwell ckbedwell ckbedwell approved these changes

Assignees

@VikaCep VikaCep

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@VikaCep @ckbedwell