fix: prevent submitting alerts per check when FF is off #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Prevents executing the new alerts
POSTrequest to update alerts when saving a check if the feature flag is off.Special notes for your reviewer:
This was a regression introduced after a refactor PR. Before, we were relying on the absence of the
alertsproperty from the form in order to save them or not. Since after the refactor thealertsprop is always present, I'm now relying on the status of the feature flag directly.Ref https://raintank-corp.slack.com/archives/C0162C1K9E1/p1739894967044089