Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripted check default example/snippet #1006

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

peterschretlen
Copy link
Contributor

What this PR does / why we need it:

This PR updates the default scripted check example to add use of the fail() function, and explains why you would use it.

Many people assume that if a check() does not pass, the test run will fail and this will impact reachability and uptime. They are unaware of the fail() function and why they should use it.

This makes the default script longer, but it is still short enough that it fits on a typical laptop screen:

image

@peterschretlen peterschretlen requested a review from a team as a code owner November 26, 2024 21:29
Copy link
Contributor

@VikaCep VikaCep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ckbedwell ckbedwell merged commit fcaf922 into main Nov 27, 2024
5 checks passed
@ckbedwell ckbedwell deleted the update-scripted-check-example branch November 27, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants