Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI support for increased MultiHTTP, scripted and browser timeouts #1048

Closed
ckbedwell opened this issue Jan 24, 2025 · 0 comments · Fixed by #1049
Closed

UI support for increased MultiHTTP, scripted and browser timeouts #1048

ckbedwell opened this issue Jan 24, 2025 · 0 comments · Fixed by #1049
Assignees
Labels
enhancement New feature or request

Comments

@ckbedwell
Copy link
Contributor

ckbedwell commented Jan 24, 2025

Problem

We are increasing the allowed timeout in scripted and browser checks to better support longer running checks. Currently the UI only allows these type of checks to timeout after up to a minute.

Acceptance criteria

(confirm confirmed with @d0ugal) -- all the below does also apply to MultiHTTP checks, as well.

  1. Increase the allowed timeout for checks to 90 seconds. Please note that this will need to be incrementally bumped in PRs at a later date to match the rollout plan as discussed in this document
  2. Add validation that the frequency can not be less than the allowed timeout. The minimum frequency for a browser / scripted check is 1 minute but as we will be increasing the timeout above this, we need to ensure that checks have the opportunity to cross-over as little as possible.
    • Display an error message beneath the frequency selector explaining it can not be less than timeout. They must adjust one or the other.
    • Do not automatically adjust the allowed frequency based on their timeout selection. We have to be explicit to the user in this scenario it is not allowed. If we adjust it for them it will be a source of confusion for the user that their desired frequency is not being honoured.
    • Ensure that the wizard form moves to step 5, displaying the error when the form is submitted from another step.
    • (confirm confirmed with @peterschretlen ) - Currently we allow timeout to be greater than frequency in the UI but the api rejects it. Please ensure endpoint checks are included in the validation.
  3. Please ensure all the above has the correct integration tests added.
@ckbedwell ckbedwell added the enhancement New feature or request label Jan 24, 2025
@VikaCep VikaCep self-assigned this Jan 24, 2025
@ckbedwell ckbedwell changed the title UI support for increased scripted and browser timeouts UI support for increased MultiHTTP, scripted and browser timeouts Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants