fix: add new probes metadata #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckbedwell
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
LGTM ⭐
This is a separate issue but when I stubbed the data in dev to spot check it, I noticed that the UI looks a bit squiffy because of the longer lines with SanFrancisco, US (Digital Ocean) [icon] and Bangalore, IN (Digital Ocean) [icon].
The probe region selections aren't all in a row and APAC gets pushed below AMER and EMEA. I reckon we could probably bump the maximum height up too.
|
I've changed the height of the columns, made them not wrap so all public probes stay in a row and renamed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1043
Adds metadata for newly added probes.