Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back frame.fields for no-rows table-queries #118

Closed
gabor opened this issue May 21, 2024 · 0 comments · Fixed by #121
Closed

add back frame.fields for no-rows table-queries #118

gabor opened this issue May 21, 2024 · 0 comments · Fixed by #121
Assignees
@gabor

Comments

@gabor
Copy link
Contributor

gabor commented May 21, 2024

with #106 an unintended change happened:

  • if you have a format=table query that returns no rows:
    • previously we made a dataframe with all the fields, except their length was zero
    • after the PR we return a frame with no fields

we should restore the previous functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabor gabor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adjusted handling of zero-rows results grafana/sqlds
1 participant
@gabor