refactor(setup-argo): refactor following feedback #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
force-pushed
the
duologic/setup-argo
branch
from
631d7e4 to
7613019
Compare
Duologic
force-pushed
the
duologic/setup-argo
branch
from
7613019 to
61be0db
Compare
Duologic
changed the title
Duologic
commented
Aug 15, 2024
| env: | ||
| OS: ${{ runner.os }} | ||
| run: | | ||
| OS=$(echo "$OS" | tr '[:upper:]' '[:lower:]') |
There was a problem hiding this comment.
Setting up both the variables in one step with a couple of case statements might be the most straightforward
There was a problem hiding this comment.
What's wrong with the current script? First lowercase it, then s/macos/darwin.
There was a problem hiding this comment.
Merging so I can keep testing it, we can iterate on the finer details in a follow up.
There was a problem hiding this comment.
I find it a bit convoluted doing all these steps when you could directly map the values
iainlane
approved these changes
Aug 15, 2024
| env: | ||
| OS: ${{ runner.os }} | ||
| run: | | ||
| OS=$(echo "$OS" | tr '[:upper:]' '[:lower:]') |
There was a problem hiding this comment.
Setting up both the variables in one step with a couple of case statements might be the most straightforward
Duologic
force-pushed
the
duologic/setup-argo
branch
from
422ab12 to
ef32e14
Compare
This was referenced Sep 25, 2024
This was referenced Sep 26, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor this action based on mob session and review feedback in relation to #212