feat: add argo-lint and install-argo-cli action #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
reviewed
Jul 3, 2024
|
Tested internally |
Duologic
changed the title
dsotirakis
approved these changes
Jul 4, 2024
iainlane
reviewed
Jul 4, 2024
Duologic
force-pushed
the
duologic/argo-lint
branch
from
e9a80d1 to
0ce83cb
Compare
Duologic
force-pushed
the
duologic/argo-lint
branch
from
0ce83cb to
11c7fba
Compare
iainlane
reviewed
Jul 4, 2024
actions/argo-lint/action.yaml
Outdated
Comment on lines
25
to
27
| # substitute your-action with a unique name (within `shared-repos` for your | ||
| # action), so if multiple actions check `shared-workflows` out, they don't | ||
| # overwrite each other |
There was a problem hiding this comment.
Suggested change
| # substitute your-action with a unique name (within `shared-repos` for your | |
| # action), so if multiple actions check `shared-workflows` out, they don't | |
| # overwrite each other |
| ARGO_VERSION=3.5.1 | ||
| echo "version=${ARGO_VERSION}" >> ${GITHUB_OUTPUT} | ||
| - name: Install argo-cli | ||
| uses: grafana/shared-workflows/actions/install-argo-cli@main |
This reverts commit 1fe126d.
Co-authored-by: Iain Lane <[email protected]>
Duologic
force-pushed
the
duologic/argo-lint
branch
from
11c7fba to
76a765e
Compare
|
Please have another look at this, I think I've covered all points. |
iainlane
approved these changes
Jul 11, 2024
|
It's running internally |
This was referenced Jul 15, 2024
This was referenced Sep 25, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured this could be an interesting shared workflow to get my feet wet in this repo.
On review, this PR splits out the installation into a separate workflow that is shared with the trigger-argo-workflow action.
Changes in this PR:
install-argo-cliactiontrigger-argo-workflowaction using aboveargo-lintaction