Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve health check #267

Open
iwysiu opened this issue Jan 5, 2024 · 1 comment
Open

Improve health check #267

iwysiu opened this issue Jan 5, 2024 · 1 comment
Labels

Comments

@iwysiu
Copy link
Contributor

iwysiu commented Jan 5, 2024

What happened:
Saving an incorrect Redshift config and the health check still returns a Data source is working message. However, as you would expect, actually running a query with the configured datasource fails.

What you expected to happen:
CheckHealth should be implemented with a simple query (maybe fetching clusters, see if that works with the secrets manager) to make sure we can actually query with the saved config.

How to reproduce it (as minimally and precisely as possible):
Save a datasource with an invalid Access and Secret Key pair, and you should observe that it saves with a Data source is working message. Then try to create a query with that datasource and it should fail.

@iwysiu iwysiu added type/bug Something isn't working datasource/Redshift labels Jan 5, 2024
@github-project-automation github-project-automation bot moved this to Incoming in AWS Datasources Jan 5, 2024
@iwysiu iwysiu moved this from Incoming to Backlog in AWS Datasources Jan 5, 2024
@idastambuk idastambuk added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 26, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last year. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants