Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner logic not working for analysers with dependencies that return nil #145

Closed
academo opened this issue Nov 8, 2023 · 1 comment
Closed

Runner logic not working for analysers with dependencies that return nil #145

academo opened this issue Nov 8, 2023 · 1 comment
Assignees
@academo

Comments

@academo
Copy link
Member

academo commented Nov 8, 2023

Some analysers require other analysers to work. When one of those dependencies return nil they never get resolved and the analyser depending on them never runs.

We should run all analysers with dependencies as long as those dependencies don't error.
@academo academo self-assigned this Nov 8, 2023
@academo academo moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Nov 10, 2023
@academo
Copy link
Member Author

academo commented Dec 8, 2023

Fixed with #147

@academo academo closed this as completed Dec 8, 2023
@github-project-automation github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@academo academo

Labels
None yet
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@academo