Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Kubernetes HPA in mimir-distributed #7846

Closed
jakubsikorski opened this issue Apr 8, 2024 · 2 comments
Closed

Native Kubernetes HPA in mimir-distributed #7846

jakubsikorski opened this issue Apr 8, 2024 · 2 comments
Labels
enhancement New feature or request helm

Comments

@jakubsikorski
Copy link

jakubsikorski commented Apr 8, 2024

Is your feature request related to a problem? Please describe.

HPA support was added in as a response to issue #3430. The added HPA solution is based on KEDA, which requires additional operator to get installed on the cluster, with metrics to be present.

Describe the solution you'd like

It would be great to add HPA based on native Kubernetes provided metrics by the metrics-server, not relying on cadvisor metrics present in Prometheus, to mimir-distributed components (same components as for KEDA).

Describe alternatives you've considered

I've attempted to use the KEDA based HPA solution, however the complexity it adds due to additional CRs needed to use this solution is high.

@narqo narqo added the helm label Apr 9, 2024
@narqo
Copy link
Contributor

narqo commented Apr 9, 2024

My understanding is that one of the motivations to pick KEDA over the "bare bone" HPA on top of the metrics-server, was the requirement to scale, base on the Mimir's own metrics (e.g. refer to ScaledObject in the querier).

Projects, that allow exposing custom Prometheus metrics to metrics-server exist (kubernetes-sigs/prometheus-adapter), although replacing KEDA with different metrics-server adaptor, doesn't seem to help with the original issue of "extra complexity" after extra components.

That being said,

I've attempted to use the KEDA based HPA solution, however the complexity it adds due to additional CRs needed to use this solution is high.

the issue #7368 tracks the work left to promote KEDA-based autoscaling to stable. It could be helpful if you shared more details about your experience. Which parts currently contribute to the additional complexity?

@narqo narqo added the enhancement New feature or request label Apr 9, 2024
@dimitarvdimitrov
Copy link
Contributor

with similar arguments to this #7870 (comment) I think we should close this

@dimitarvdimitrov dimitarvdimitrov closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm
Projects
None yet
Development

No branches or pull requests

3 participants