Feature Request: Move mimirclient to dskit

[gotjosh]

I propose we move https://github.com/grafana/mimir/tree/main/pkg/mimirtool/client to https://github.com/grafana/dskit.

Personally, I need to use the client as part of Grafana but would like to avoid importing any part of Mimir directly. I can see this client doesn't see enough change that moving it outside of grafana/mimir would be a major problem.

Any thoughts?

[56quarters]

I'm not a fan of moving the client:

• Outside Mimir. It's very specific to Mimir and having it outside the repo would make maintenance more difficult. E.g. we moved cortextool to mimirtool inside the Mimir repo to make things easier to version together.
• I definitely don't think it belongs in dskit. It's very specific to Mimir and dskit is meant to be reusable components for the databases (and potentially other projects).

Since the goal is calling Mimir APIs without having all of Mimir as a dependency for Grafana, maybe a little copy/paste would be acceptable? The HTTP APIs of Mimir don't change without a major version bump (I think).

[gotjosh]

Thank you both @56quarters and @pstibrany -- I don't feel too strongly about this one, so I'm happy to go for the copy/paste approach and assume the risk that comes with it.

Keep in mind that:

The HTTP APIs of Mimir don't change without a major version bump (I think).

This doesn't apply to us (Grafana Labs) given Mimir and Grafana are rolled out at a completely different cadence to our cloud services. That being said, we're pretty good in the Mimir side at keeping ourselves true to breaking changes.