diff --git a/.github/workflows/helm-diff-ci.yml b/.github/workflows/helm-diff-ci.yml index 64e966140cbe1..2bacfd2d25dd6 100644 --- a/.github/workflows/helm-diff-ci.yml +++ b/.github/workflows/helm-diff-ci.yml @@ -3,8 +3,9 @@ name: Helm Loki Diff CI on: pull_request: paths: - - 'production/helm/loki/**' + - "production/helm/loki/**" +# These permissions are needed to assume roles from Github's OIDC. permissions: contents: read pull-requests: write @@ -273,6 +274,7 @@ jobs: summary-diff-outputs: name: Summary Diffs runs-on: ubuntu-latest + if: github.event.pull_request.head.repo.fork == false needs: - single-binary-diff - default-values-diff @@ -283,6 +285,8 @@ jobs: steps: - name: Checkout code uses: actions/checkout@v4 + with: + persist-credentials: false - uses: actions/download-artifact@v4 with: diff --git a/production/helm/loki/scenarios/README.md b/production/helm/loki/scenarios/README.md index b84c186e23684..496286bb2009d 100644 --- a/production/helm/loki/scenarios/README.md +++ b/production/helm/loki/scenarios/README.md @@ -61,3 +61,9 @@ As the last step you need to run a diff between both files: ```shell diff current-manifest.yaml release-manifest.yaml ``` + +### Known Issues + +* The Github Action won't be able to post the diff comment if the PR is coming from a fork, because of permissions the workflow run from a fork is not able to write in the PR content. + + In this case, to review the output we recommend to download the artifacts in the workflow run and check the outputs. diff --git a/production/helm/loki/scenarios/images/added.png b/production/helm/loki/scenarios/images/added.png deleted file mode 100644 index ced9f9554a8f8..0000000000000 Binary files a/production/helm/loki/scenarios/images/added.png and /dev/null differ diff --git a/production/helm/loki/scenarios/images/img.png b/production/helm/loki/scenarios/images/img.png deleted file mode 100644 index 81ba701da26a0..0000000000000 Binary files a/production/helm/loki/scenarios/images/img.png and /dev/null differ diff --git a/production/helm/loki/scenarios/images/modified.png b/production/helm/loki/scenarios/images/modified.png deleted file mode 100644 index 39a25bae35b20..0000000000000 Binary files a/production/helm/loki/scenarios/images/modified.png and /dev/null differ diff --git a/production/helm/loki/scenarios/images/removed.png b/production/helm/loki/scenarios/images/removed.png deleted file mode 100644 index 219d64c32c983..0000000000000 Binary files a/production/helm/loki/scenarios/images/removed.png and /dev/null differ