Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling health_check_ingesters: true leads to panics. #1829

Closed
pstibrany opened this issue Mar 20, 2020 · 3 comments
Closed

Enabling health_check_ingesters: true leads to panics. #1829

pstibrany opened this issue Mar 20, 2020 · 3 comments
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@pstibrany
Copy link
Member

Structure returned by

loki/pkg/ingester/client/client.go

Line 35 in 107dfd3

func New(cfg Config, addr string) (grpc_health_v1.HealthClient, error) {
has no implementation for grpc_health_v1.HealthClient, so calling methods of this interface panics.

This happens if someone enables 'health_check_ingesters: true'.

Loki 1.3.0
@owen-d owen-d added the keepalive An issue or PR that will be kept alive and never marked as stale. label Mar 20, 2020
@adityacs
Copy link
Contributor

@pstibrany @owen-d we have fixed this in #1730

@pstibrany
Copy link
Member Author

@pstibrany @owen-d we have fixed this in #1730

Great, I missed that! Thank you!

@owen-d
Copy link
Member

owen-d commented Mar 20, 2020

Awesome, what a nice surprise.

Thanks @adityacs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pstibrany @adityacs @owen-d