Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic in pattern ingester read path #13043

Closed
cyriltovena opened this issue May 27, 2024 · 1 comment
Closed

Panic in pattern ingester read path #13043

cyriltovena opened this issue May 27, 2024 · 1 comment
Labels
type/bug Somehing is not working as expected

Comments

@cyriltovena
Copy link
Contributor

Seems like we can sometimes panic with errors like runtime error: makeslice: cap out of range looking at the stacktraces it seems to come from https://github.com/grafana/loki/pull/12703/files#diff-472ead11f0a321ec18f4d3cb58f65a59bc7e8b3a172fc00e77a8dc10830d676cR75

@benclive
Copy link
Contributor

Opened a fix in #13010. The root cause seems to be out-of-order writes to the pattern ingester which are rare but perfectly valid, so we just need to handle them.

@JStickler JStickler added the type/bug Somehing is not working as expected label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Somehing is not working as expected
Projects
None yet
Development

No branches or pull requests

3 participants