-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator): Configure Loki to use virtual-host-style URLs for S3 AWS endpoints #12469
Conversation
66359ec
to
7461436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test it yet with any cluster, but setting the s3forcepathstyle
attribute based on whether we're actually using AWS is a nice workaround for not being able to break compatibility with other providers.
One general remark would be to put less of the logic into the go-template: instead of having a function and a conditional running in the template, move the force path style
into an attribute of the context provided to the template and set the value from outside the template.
What this PR does / why we need it:
Change Loki's configuration to use virtual-host-style instead of path-style URLs when the object storage endpoint is AWS S3.
Which issue(s) this PR fixes:
Fixes LOG-5051
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR