Skip to content

Commit ede6941

Browse files
authored
fix(blooms): ignores bloom filtering errors in bounded shard query planning (#13285)
1 parent eb1cd4c commit ede6941

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pkg/indexgateway/gateway.go

+5-2
Original file line numberDiff line numberDiff line change
@@ -465,12 +465,15 @@ func (g *Gateway) boundedShards(
465465
// 2) filter via blooms if enabled
466466
filters := syntax.ExtractLineFilters(p.Plan().AST)
467467
if g.bloomQuerier != nil && len(filters) > 0 {
468-
filtered, err = g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan())
468+
xs, err := g.bloomQuerier.FilterChunkRefs(ctx, instanceID, req.From, req.Through, refs, p.Plan())
469469
if err != nil {
470-
return err
470+
level.Error(logger).Log("msg", "failed to filter chunk refs", "err", err)
471+
} else {
472+
filtered = xs
471473
}
472474
sp.LogKV(
473475
"stage", "queried bloom gateway",
476+
"err", err,
474477
)
475478
}
476479

0 commit comments

Comments
 (0)