Skip to content

Commit 4220737

Browse files
authored
feat(exporter): include boolean values in limit exporter (#13466)
1 parent e08b4a7 commit 4220737

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

pkg/validation/exporter.go

+6
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@ func (oe *OverridesExporter) Collect(ch chan<- prometheus.Metric) {
5656
return float64(val.Field(i).Uint()), true
5757
case float64:
5858
return val.Field(i).Float(), true
59+
case bool:
60+
v := 0.0
61+
if val.Field(i).Bool() {
62+
v = 1.0
63+
}
64+
return v, true
5965
default:
6066
return 0, false
6167
}

pkg/validation/exporter_test.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,13 @@ func TestOverridesExporter_noConfig(t *testing.T) {
3535
func TestOverridesExporter_withConfig(t *testing.T) {
3636
tenantLimits := map[string]*Limits{
3737
"tenant-a": {
38-
MaxQueriersPerTenant: 5,
38+
MaxQueriersPerTenant: 5,
39+
BloomCompactorEnabled: true,
3940
},
4041
}
4142
overrides, _ := NewOverrides(Limits{}, newMockTenantLimits(tenantLimits))
4243
exporter := NewOverridesExporter(overrides)
4344
count := testutil.CollectAndCount(exporter, "loki_overrides")
44-
assert.Greater(t, count, 0)
45+
assert.Equal(t, 2, count)
4546
require.Greater(t, testutil.CollectAndCount(exporter, "loki_overrides_defaults"), 0)
4647
}

0 commit comments

Comments
 (0)