feat: test packages separately #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstyan
approved these changes
Apr 19, 2024
| collectPackages: job.new() | ||
| + job.withSteps([ | ||
| common.checkout, | ||
| common.fixDubiousOwnership, |
There was a problem hiding this comment.
haha, that's the error git gives when doing git stuff in a mounted volume in a container
| + step.withId('gather-tests') | ||
| + step.withRun(||| | ||
| echo "packages=$(find . -path '*_test.go' -printf '%h\n' \ | ||
| | grep -e "pkg/push" -e "integration" -e "operator" -e "lambda-promtail" -v \ |
There was a problem hiding this comment.
so to be clear, we're not running the integration or operator tests anymore? and pkg/push and lambda-promtail will be run as separate jobs?
There was a problem hiding this comment.
not running operator, correct, it has it's own workflow that's guarded on changes to that folder. we are running integration tests just in a different, parallel job
|
going to merge monday in case there's fallout |
This was referenced Dec 12, 2024
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
checkphase of our build (that runs for both releases and PRs) by ~4m, decreasing the current runtime of ~9m30s to ~5m30s. It does this by splitting out our tests in a job per package using GitHub actions 'matrix' job strategy.This is what it will look like run on
grafana/loki: https://github.com/grafana/loki/actions/runs/8726432895