Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata to reflection in grpc #3241

Closed
gubtos opened this issue Aug 1, 2023 · 1 comment · Fixed by #3343
Closed

add metadata to reflection in grpc #3241

gubtos opened this issue Aug 1, 2023 · 1 comment · Fixed by #3343
Labels

Comments

@gubtos
Copy link

gubtos commented Aug 1, 2023

Feature Description

Reflection call on grpc Connect don`t support metadata.

https://github.com/grafana/k6/blob/master/js/modules/k6/grpc/client.go#L263

Current params parsing

https://github.com/grafana/k6/blob/master/js/modules/k6/grpc/client.go#L495-L583

Suggested Solution (optional)

Add to reflection context the metadata from params argument

Already existing or connected issues / PRs (optional)

No response

@olegbespalov
Copy link
Contributor

Would it be helpful to introduce the GRPC connection's default metadata, which could be automatically passed by default to the places that support metadata (unary's invoke, stream's, reflection calls)? In case of the presence of in-line metadata, they should have priority.

@grafana/k6-core, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants