Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snake_case to camelCase in argline for csv and influxdb outputs #2137

Closed
mstoykov opened this issue Sep 14, 2021 · 7 comments
Closed

Fix snake_case to camelCase in argline for csv and influxdb outputs #2137

mstoykov opened this issue Sep 14, 2021 · 7 comments

Comments

@mstoykov
Copy link
Contributor

Throughout k6 we use camelCase for JSON options and CAPS_SNAKE_CASE for env variables. The few places where there are argline options such as k6 run -o csv=file_name=something.csv we sometimes use snake_case as in the CSV output and one option in the influxdb one, but sometimes we use camelCase as in the loki logs and the rest of the influxdb options :(.

Given that there really isn't a good case for one of the options to be camelCase and the other snake_case we should make them the same. For backwards compatible reasons we should still parse the snake_case variant and warn the user through a log message, at least for ... some versions.

So I propose that @codebien fixes the influxdb one in #2110 and there to be a separate PR for the CSV output.

@Sampriti-Mitra
Copy link

@mstoykov can I take this

@mstoykov
Copy link
Contributor Author

Go for it @Sampriti-Mitra ! Just FYI if you want to do it as part of hacktoberfest, you might need to wait another 3 days or so, although maybe it's fine, I haven't really read the fine print 🤷‍♂️

@josephwoodward
Copy link
Contributor

Hi @Sampriti-Mitra, are you working on this? If not I have a pull request here that I'd like to propose.

@Sampriti-Mitra
Copy link

@mstoykov sure, will be working on this!

@Sampriti-Mitra
Copy link

@josephwoodward think your PR looks good, @mstoykov can you assign this to @josephwoodward instead

@josephwoodward
Copy link
Contributor

Hi, @mstoykov. I believe this issue can now be closed.

@na-- na-- closed this as completed Oct 8, 2021
@na--
Copy link
Member

na-- commented Oct 8, 2021

The influxdb fixes are still pending in #2110, but there are other obstacles there, so there's no point in holding this up with them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants