feat: Add text selector #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-fisher
commented
Jan 22, 2025
| @@ -25,3 +31,32 @@ export function replaceCorrelatedValues({ | |||
| value: varName, | |||
| }) | |||
| } | |||
|
|
|||
| function replaceAllTextMatches( | |||
There was a problem hiding this comment.
Move function here from shared.ts because it's the only place where it's used.
Comment on lines
+81
to
+86
| export const ExtractorSelectorSchema = z.discriminatedUnion('type', [ | ||
| BeginEndSelectorSchema, | ||
| RegexSelectorSchema, | ||
| JsonSelectorSchema, | ||
| HeaderNameSelectorSchema, | ||
| ]) |
There was a problem hiding this comment.
Split Selector schema into Extractor and Replacer, because Text selector doesn't apply to extractions
This was referenced Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add text selector to exact string match replacements. Previously you'd have to use a workaround with regex selector: regex: (value_to_be_placed).
This selector applies to parameterization rule and correlation rule custom replacer, but not correlation extractor, because it doesn't make sense to correlate on static value.
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)
Resolves #315