chore: threshold schema, slice and migration #425
Conversation
src/schemas/generator/v2/index.ts
Outdated
| allowlist: z.string().array(), | ||
| includeStaticAssets: z.boolean(), | ||
| scriptName: z.string().default('my-script.js'), | ||
| thresholds: z.array(ThresholdSchema), |
There was a problem hiding this comment.
The thresholds array is the only addition here.
| @@ -0,0 +1,42 @@ | |||
| import { z } from 'zod' | |||
There was a problem hiding this comment.
This Schema may evolve to include validation and potentially some conditional transform operations.
It is based on the Thresholds feature available in the Test Builder.
| interface State { | ||
| thresholds: Array<Threshold> | ||
| } | ||
|
|
||
| interface Actions { | ||
| addThreshold: (threshold: Threshold) => void | ||
| updateThreshold: (threshold: Threshold) => void | ||
| deleteThreshold: (id: string) => void | ||
| } |
There was a problem hiding this comment.
Initial state and actions to get some UI and validation working in the upcoming branch.
src/schemas/generator/v2/index.ts
Outdated
| allowlist: z.string().array(), | ||
| includeStaticAssets: z.boolean(), | ||
| scriptName: z.string().default('my-script.js'), | ||
| thresholds: z.array(ThresholdSchema), |
There was a problem hiding this comment.
I think you might be able to avoid adding a new schema version if you default thresholds to an empty array:
thresholds: z.array(ThresholdSchema).default([])Since it's a new property added to schema, all what migrate does is initiate an empty array, which can be done using zod's default method.
There was a problem hiding this comment.
This worked perfectly, thanks for the suggestion! 🙏
Description
This PR is part of the Thresholds feature #369. It contains the initial setup including the Schema, Slice, and Migration.
How to Test
Checklist
npm run lint) and all checks pass.npm test) and all tests pass.Screenshots (if appropriate):
Related PR(s)/Issue(s)