Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo: Caching of tag values doesn't update with new conditions #77380

Closed
Tracked by #2957
mapno opened this issue Oct 30, 2023 · 4 comments · Fixed by #79468
Closed
Tracked by #2957

Tempo: Caching of tag values doesn't update with new conditions #77380

mapno opened this issue Oct 30, 2023 · 4 comments · Fixed by #79468

Comments

@mapno
Copy link
Member

mapno commented Oct 30, 2023

What happened?

When using TraceQL with autocomplete filtering enabled, tag values are cached and never refreshed when there are new conditions.

What did you expect to happen?

Values to be refreshed to match the new query.

Did this work before?

No.

How do we reproduce it?

  1. Type a valid set of conditions and then wait for Grafana to fetch values for a new attribute—{ resource.cluster="foo" && span.http.route=}.
  2. After a few seconds, values for span.http.route will apear that match resource.cluster="foo"
  3. Change any of the other conditions and query for the same attribute again—{ resource.cluster="bar" && span.http.route=}.
  4. The same values from the previous query will be suggested.

Is the bug inside a dashboard panel?

No response

Environment (with versions)?

No response

Grafana platform?

None

Datasource(s)?

Tempo

@fabrizio-grafana
Copy link
Contributor

fabrizio-grafana commented Oct 31, 2023

👋
Are you referring to the support for this Tempo feature? If so, I think you are right, meaning that as of now the TraceQL query editor in Grafana is probably not aware of this filtering directly done by Tempo, but it is definitely worth to update the editor to take advantage of it.

@mapno
Copy link
Member Author

mapno commented Oct 31, 2023

Are you referring to the support for this Tempo feature?

Yes, that one.

@09jvilla
Copy link
Contributor

09jvilla commented Nov 7, 2023

@fabrizio-grafana - Is it fair to call this a bug? I thought about adding that label.

@fabrizio-grafana
Copy link
Contributor

@09jvilla Yeah I think it's a fair call. I'll add the label!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants