Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docker base to node:10-alpine #36

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Switch docker base to node:10-alpine #36

merged 1 commit into from
Sep 9, 2019

Conversation

marefr
Copy link
Contributor

@marefr marefr commented Sep 9, 2019

Swtich from node:10 to node:10-alpine.

  • Better from a security point.
  • Smaller image 535MB vs 1.66GB

This works on my machine, but the current docker image installs a lot of additional dependencies related to fonts etc so I'm unsure if my suggested changes is enough.

@marefr marefr requested a review from torkelo September 9, 2019 19:34
@marefr marefr merged commit 629405e into master Sep 9, 2019
@marefr marefr deleted the docker_alpine branch September 9, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant