Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-tracing): attach user attributes to spans #990

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

codecapitano
Copy link
Collaborator

Why

The web-tracing instrumentation now takes care to add user attributes to spans.

The UserMeta was updated with more properties to be aligned with otel semantic conventions for user.

What

  • Add missing attributes to user meta to be compatible with otel semantic attributes
  • create new span exporter which takes care of adding session and user attributes to spans

Links

Checklist

  • Tests added
  • Changelog updated
  • Documentation updated

@codecapitano codecapitano added feature Request a new feature improvement Request a change of an existing feature labels Feb 20, 2025
@codecapitano codecapitano self-assigned this Feb 20, 2025
@codecapitano codecapitano linked an issue Feb 20, 2025 that may be closed by this pull request
@codecapitano codecapitano removed the feature Request a new feature label Feb 20, 2025
@codecapitano codecapitano force-pushed the 540-web-tracing-attach-user-attributes-to-spans branch from 3dfc870 to 61d3d84 Compare February 20, 2025 11:28
@codecapitano codecapitano marked this pull request as ready for review February 20, 2025 11:32
@codecapitano codecapitano changed the title chore(web-tracing) attach user attributes to spans chore(web-tracing): attach user attributes to spans Feb 20, 2025
@codecapitano codecapitano requested a review from rrmf February 20, 2025 13:26
Copy link

@rrmf rrmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@codecapitano codecapitano merged commit 76b8578 into main Feb 20, 2025
9 checks passed
@codecapitano codecapitano deleted the 540-web-tracing-attach-user-attributes-to-spans branch February 20, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Request a change of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-tracing: Attach user attributes to spans
2 participants