feat(*): Various minor improvements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
grafakus
commented
Jul 12, 2024
| @@ -371,37 +369,15 @@ export class SceneProfilesExplorer extends SceneObjectBase<SceneProfilesExplorer | |||
| <> | |||
| <div className={styles.header}> | |||
| <div className={styles.controls}> | |||
| <Stack justifyContent="space-between" wrap="wrap"> | |||
| <Stack justifyContent="space-between"> | |||
There was a problem hiding this comment.
This unfortunately does not completely fix #41, the time picker does not shrink on narrow screen. I will have to investigate further why
bryanhuhta
approved these changes
Jul 12, 2024
| } | ||
|
|
||
| if (bIsFav) { | ||
| return +1; |
There was a problem hiding this comment.
Interesting that +1 is a valid js number. I did not know this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s):
-Just some cosmetics changes, among them:
📖 Summary of the changes
See diff tab for more details
🧪 How to test?