-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[diff flame graph view] Clarify what the user has to do to see the diff flame graph #224
Comments
I think we should do the following... we should consider two states:
https://github.com/user-attachments/assets/c5f19fcc-fdbd-4aac-8fee-be025ad3c47b User has never selected anything and is just now landing on a "blank" diff pageI believe in this case we need to teach the user that they need to select something on the timeline. We can do this via two options:
If we anted to get really fancy maybe we could even highlight the border of the line graphs panel until a user has selected something on the pink one and then highlight the border on the blue line graph panel until a user has selected both (we could also change the gif to be pink or blue depending on what they have / have not highlighted) User has landed on the diff page but is now selecting a new time rangeThe whole point of us not automatically showing a flamegraph is so that we can change the time ranges independently from the flamegraph calculation. If a user changes the time range... Let's say from "last 30 minutes" to "last 7 days" we should not automatically calculate the flamegraph. Instead we should again show the same gif as above that instructs the user to select the time ranges and then only after that should we calculate the flamegraph. What does this solveWhat this solves is:
|
Hi Ryan, sorry for the late answer but I think we covered this face to face... Note that the time range and flame graph range selections are independent: when you select a new time range with the time picker, the flame graph range is not modified. I hope that the 2 new CTAs and the presets will help our users. And I'm also convinced that #242 will do too, based on internal feedback. Let's iterate! |
Feature description
Is your feature request related to a problem? Please describe.
When landing on the "Diff flame graph view", it's not 100% clear which selections have to be made in order to view a diff flame graph, some users might end up in a situation like:
Without understanding that they haven't selected the flame graph ranges on the time series:
Describe the solution you'd like
Suggestion: "In Flame graph mode, select both the baseline and the comparison flame graph time range, using your mouse, to view the diff flame graph."
Alternatives considered
Describe alternatives you've considered
-
Additional context
Slack conversation: https://raintank-corp.slack.com/archives/C03NCLB4GG7/p1729081997377229 (cc @adamquan)
The text was updated successfully, but these errors were encountered: