Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SingleView): Remove page #20

Merged
merged 3 commits into from
Jul 10, 2024
Merged

feat(SingleView): Remove page #20

merged 3 commits into from
Jul 10, 2024

Conversation

grafakus
Copy link
Contributor

✨ Description

Related issue(s): relates to #5

The Explore Profiles app includes the "Flame graph" exploration type, which is essentially a clone of the Single View.

This PR removes it.

📖 Summary of the changes

See diff tab.

🧪 How to test?

  • The build should pass

@grafakus grafakus requested a review from bryanhuhta July 10, 2024 10:11
const history = useHistory();
const shouldRedirectSingleView = history.location.pathname.includes('/single');

if (shouldRedirectSingleView) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary

Copy link
Contributor

github-actions bot commented Jul 10, 2024

Unit test coverage

Lines Statements Branches Functions
Coverage: 12%
12.51% (446/3564) 10.29% (134/1301) 9.52% (102/1071)

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@grafakus grafakus merged commit 16da70d into main Jul 10, 2024
5 checks passed
@grafakus grafakus deleted the feat/remove-single-view branch July 10, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants