Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(QuickFilter): Add results count #193

Merged
merged 5 commits into from
Sep 27, 2024
Merged

feat(QuickFilter): Add results count #193

merged 5 commits into from
Sep 27, 2024

Conversation

grafakus
Copy link
Contributor

@grafakus grafakus commented Sep 26, 2024 •
edited
Loading

✨ Description

Related issue(s): -

This PR adds the number of results in the quick filter bar (1692):

image

📖 Summary of the changes

See diff tab

🧪 How to test?

  1. The new E2E tests should pass in the CI build

  2. Manually:

  • The results count should appear when landing on the page and when updating/clearing the search text
  • The count should be displayed in the "All services", "Profile types", "Labels" and "Favorites" views

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024 •
edited
Loading

Unit test coverage

Lines Statements Branches Functions
Coverage: 10%
 10.74% (416/3873) 8.58% (115/1340) 8.25% (101/1224)

@grafakus grafakus requested a review from bryanhuhta September 26, 2024 17:18
@grafakus grafakus merged commit dc4012d into main Sep 27, 2024
7 checks passed
@grafakus grafakus deleted the feat/add-quick-filter-results-count branch September 27, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanhuhta bryanhuhta bryanhuhta approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grafakus @bryanhuhta