feat(FlameGraph): Add missing export menu #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be set on the timeseries data
grafakus
changed the title
Unit test coverage
|
grafakus
commented
Aug 26, 2024
| @@ -0,0 +1,28 @@ | |||
| import { Field, Message } from 'protobufjs/light'; | |||
|
|
|||
| export class PprofRequestWithoutMaxNodes extends Message<PprofRequestWithoutMaxNodes> { | |||
There was a problem hiding this comment.
Just renamed it to prevent runtime errors (protobufjs/protobuf.js#1408). This class will be removed very soon because it was used for the legacy comparison pages.
# Conflicts: # src/pages/ProfilesExplorerView/components/SceneAiPanel/infrastructure/useFetchDotProfiles.ts # src/pages/ProfilesExplorerView/components/SceneExploreServiceFlameGraph/SceneFlameGraph.tsx
grafakus
commented
Aug 26, 2024
| @@ -14,6 +15,8 @@ export function useExportMenu({ profile, enableFlameGraphDotComExport }: ExportD | |||
| const [timeRange] = useTimeRangeFromUrl(); | |||
|
|
|||
| const downloadPng = () => { | |||
| reportInteraction('g_pyroscope_export_profile', { format: 'png' }); | |||
There was a problem hiding this comment.
Adding missing tracking here as well.
|
I just gave it a quick test: PNG ✅
JSON ✅
PPROF ✅
flamegraph.com ✅
Unsure if the minor PPROF issue I encountered is due to something we are doing or something flamegraph.com is missing but I am leaning towards the latter because |
ifrost
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s): solves #104, is blocked by #129
📖 Summary of the changes
Most of the code already existed, this PR just uses it in a new
SceneExportMenuclass.Note that, because the Scenes app uses data frames, but the JSON and the flamegraph.com exports require the Flamebearer format, we have to fetch the Flamebearer profile before being able to proceed to the export.
Ideally, in the near future, we should just convert the data frames to the Flamebearer format without any request to the API.
🧪 How to test?
Manually, by exporting to the 4 different formats and verifying that the data is correct.
For JSON and PPROF, this can be done by uploading them in the AdHoc view (http://localhost:3000/a/grafana-pyroscope-app/ad-hoc) and verify that they match.
Again, very soon, we should automate by adding E2E tests.